[AzCopyV10][Bug] Uploading from top directory on linux fails when sub folder has the same name

[siminsavani-msft]

Line 19 in cmd/copyEnumeratorHelper.go causes a bug in linux in which the root folder name is removed from path.

i.e. e.SourceRoot.Value = "/event" and transfer.Source = "/event_stuff/foo.txt" --> incorrectly changes transfer.Source to "_stuff/foo.txt"

The transfer.Source is already a relative path and this line of code can be removed.

---

Refactoring AzCopy copy to use scheduleCopyTransfer instead of addTransfer.

Steps of scheduleCopyTransfer:

1. Gets source and destination relative path from stored object (transfer)
2. Sets up copy transfer and figures out if stored object should be sent to STE
3. If destination is none, then blobtier, metadata, and blob tags are set accordingly
4. If the stored object should not be sent to STE, it skips this object
5. If transfer has dry run mode on, it logs info and skips the object
6. If the length of transfers is same as number of transfers per part, then reset transfers buffer
7. Append transfer to list after checking and dispatching a part
8. If transfer type is file, increment file count or else increment folder count

Steps of addTransfer:

1. Trims prefix for source and destination url (to get relative paths for both)
2. Dispatch transfers once number of files reaches the number of files per dispatch job part (10000) and reset transfers buffer.
3. Append transfer to transfer list after a part has been checked and dispatched
4. If transfer type is file, increment file count or else increment folder count

[adreed-msft]

is transfer.Destination not a similar case? Does this bug end up existing on the destination?

[siminsavani-msft]

Good call out! I removed the transfer.Destination (in the new draft PR) as well because transfer.Destination will always have relative path.

[siminsavani-msft]

Closing this PR and creating fresh PR here: #2125