Allow calling app to cancel enumeration and handle scanning directory errors in traverser #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase with |
Created a work item for the same. |
Strikerzee
force-pushed
the
personal/arnav/cancel-enumeration-fix-scandir-err
branch
from
da38610
to
1743806
Compare
- Used appCtx in parallel-walk so that when app want to cancel the enumeration it can do. - It doesn't effect azcopy working.
* Fail visibly when scanning fails for files and directories * add in more error paths * fix processOneDirectory changes and add more comments
Strikerzee
force-pushed
the
personal/arnav/cancel-enumeration-fix-scandir-err
branch
from
1743806
to
e1bd6f1
Compare
mohsha-msft
reviewed
Jun 13, 2022
mohsha-msft
approved these changes
Jun 14, 2022
nakulkar-msft
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable calling app to cancel enumeration
Handle scanning directory errors in traverser.