Fix race between Updating JobPart and xferDoneMsg #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakulkar-msft
force-pushed
the
nakulkar/private/raceOnJobStatusMgr
branch
from
477ac22
to
f2aca48
Compare
Merged
nakulkar-msft
requested review from
zezha-msft,
mohsha-msft,
nitin-deamon and
adreed-msft
Strikerzee
approved these changes
Jun 14, 2022
ste/jobStatusManager.go
Outdated
| listReq chan struct{} | ||
| partCreated chan JobPartCreatedMsg | ||
| xferDone chan xferDoneMsg | ||
| xferDoneDrained chan struct{} |
There was a problem hiding this comment.
It would greatly help if we could add a comment explaining that these 2 new variables have been added in order to fix the race condition. Otherwise, it does not look very obvious to me
siminsavani-msft
approved these changes
Jun 17, 2022
nakulkar-msft
force-pushed
the
nakulkar/private/raceOnJobStatusMgr
branch
from
e12917b
to
4064d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XDM folks have seen a race between ReportJobPartDone() and handleStatusUpdateMessage(), which would cause handleStatusUpdateMessage() to report incorrect statistics wrt. JobSummary. This PR will fix the race.