Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error on failure to split URL #2271

Merged
merged 1 commit into from Jul 5, 2023
Merged

Conversation

gapra-msft
Copy link
Member

@gapra-msft gapra-msft commented Jun 27, 2023

Resolves #2183

This will result in the code panicing or erroring out if a file share url is passed without a sas

@gapra-msft gapra-msft added this to the 10.20 milestone Jun 27, 2023
@gapra-msft gapra-msft linked an issue Jun 27, 2023 that may be closed by this pull request
@gapra-msft gapra-msft added the bug label Jun 27, 2023
@gapra-msft gapra-msft changed the title return error on failure to parse URL Return error on failure to split URL Jun 27, 2023
@gapra-msft gapra-msft merged commit 4509826 into dev Jul 5, 2023
17 checks passed
@gapra-msft gapra-msft deleted the gapra/filesidentitylog branch July 5, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for Azure Files to Azure Files Sync Using Identity
3 participants