Minimise mumber of calls to folder create

ste/folderCreationTracker.go

@@ -85,6 +85,11 @@ func (f *jpptFolderTracker) CreateFolder(folder string, doCreation func() error)
 		return nil // Never persist to dev-null
 	}
 
+	if idx, ok := f.contents[folder]; ok &&
+		f.plan.Transfer(idx).TransferStatus() == (common.ETransferStatus.FolderCreated()) {
+			return nil
+	}
+
 	err := doCreation()
 	if err != nil {
 		return err

ste/sender-azureFile.go

@@ -531,39 +531,28 @@ func (d AzureFileParentDirCreator) CreateParentDirToRoot(ctx context.Context, fi
 }
 
 func (d AzureFileParentDirCreator) CreateDirToRoot(ctx context.Context, shareClient *share.Client, directoryClient *directory.Client, t FolderCreationTracker) error {
-	fileURLParts, err := file.ParseURL(directoryClient.URL())
-	if err != nil {
-		return err
-	}
-	_, err = directoryClient.GetProperties(ctx, nil)
-	if err != nil {
-		var respErr *azcore.ResponseError
-		if errors.As(err, &respErr) && (respErr.StatusCode == http.StatusNotFound || respErr.StatusCode == http.StatusForbidden) {
-			// Either the parent directory does not exist, or we may not have read permissions.
-			// Try to create the parent directories. Split directories as segments.
-			segments := d.splitWithoutToken(fileURLParts.DirectoryOrFilePath, '/')
-			currentDirectoryClient := shareClient.NewRootDirectoryClient() // Share directory should already exist, doesn't support creating share
-			// Try to create the directories
-			for i := 0; i < len(segments); i++ {
-				currentDirectoryClient = currentDirectoryClient.NewSubdirectoryClient(segments[i])
-				rawURL := currentDirectoryClient.URL()
-				recorderURL, err := url.Parse(rawURL)
-				if err != nil {
-					return err
-				}
-				recorderURL.RawQuery = ""
-				err = t.CreateFolder(recorderURL.String(), func() error {
-					_, err := currentDirectoryClient.Create(ctx, nil)
-					return err
-				})
-				if verifiedErr := d.verifyAndHandleCreateErrors(err); verifiedErr != nil {
-					return verifiedErr
-				}
-			}
-		} else {
+	// ignoring error below because we're getting URL from a valid client.
+	fileURLParts, _ := file.ParseURL(directoryClient.URL())
+
+	// Try to create the parent directories. Split directories as segments.
+	segments := d.splitWithoutToken(fileURLParts.DirectoryOrFilePath, '/')
+	currentDirectoryClient := shareClient.NewRootDirectoryClient() // Share directory should already exist, doesn't support creating share
+	// Try to create the directories
+	for i := 0; i < len(segments); i++ {
+		currentDirectoryClient = currentDirectoryClient.NewSubdirectoryClient(segments[i])
+		rawURL := currentDirectoryClient.URL()
+		recorderURL, err := url.Parse(rawURL)
+		if err != nil {
 			return err
 		}
+		recorderURL.RawQuery = ""
+		err = t.CreateFolder(recorderURL.String(), func() error {
+			_, err := currentDirectoryClient.Create(ctx, nil)
+			return err
+		})
+		if verifiedErr := d.verifyAndHandleCreateErrors(err); verifiedErr != nil {
+			return verifiedErr
+		}
 	}
-	// Directly return if parent directory exists.
 	return nil
 }