Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix]FileShare and Resume Job fix #2515

Merged
merged 3 commits into from Jan 2, 2024
Merged

[BugFix]FileShare and Resume Job fix #2515

merged 3 commits into from Jan 2, 2024

Conversation

pranavmalik-msft
Copy link
Collaborator

@pranavmalik-msft pranavmalik-msft commented Dec 31, 2023 •
edited

Description

  • This pull request addresses the reported issue where Azcopy fails to function properly when the destination directory has the 'read-only' attribute set, even when utilizing the 'force-if-read-only' flag.
  • Addressing the reported issue where job resumptions were leading to the creation of multiple log files within the Azure Storage AzCopy tool.

Changes:

  • Implemented a comprehensive fix to rectify the observed behavior, ensuring Azcopy functions correctly even when encountering directories with the 'read-only' attribute.
  • Added validation checks.
  • Implemented a fix to ensure that log files are appropriately handled when jobs are resumed.
  • Introduced validation checks to prevent the creation of redundant log files during job resumption scenarios.

@pranavmalik-msft pranavmalik-msft changed the title [BugFix]AzCopy fails when destination directory has ReadOnly attribute set, despite using force-if-read-only flag [BugFix]FileShare Fix ,Resume Job fix Dec 31, 2023
@pranavmalik-msft pranavmalik-msft changed the title [BugFix]FileShare Fix ,Resume Job fix [BugFix]FileShare and Resume Job fix Dec 31, 2023
@vibhansa-msft vibhansa-msft modified the milestones: 10.23.0, 10.23 Jan 2, 2024
@pranavmalik-msft pranavmalik-msft merged commit 7e0e215 into dev Jan 2, 2024
23 checks passed
@vibhansa-msft vibhansa-msft linked an issue Jan 18, 2024 that may be closed by this pull request
Failed files on first run of copy corrupt the stats of the job on resume #2461
Closed
@BrewTestBot BrewTestBot mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nakulkar-msft nakulkar-msft nakulkar-msft approved these changes

@vibhansa-msft vibhansa-msft vibhansa-msft approved these changes

@gapra-msft gapra-msft Awaiting requested review from gapra-msft gapra-msft is a code owner

@adreed-msft adreed-msft Awaiting requested review from adreed-msft adreed-msft is a code owner

@siminsavani-msft siminsavani-msft Awaiting requested review from siminsavani-msft siminsavani-msft is a code owner

@tasherif-msft tasherif-msft Awaiting requested review from tasherif-msft

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

Assignees
No one assigned
Labels
pr-ready-for-review
Projects
None yet
Milestone
10.23
Development

Successfully merging this pull request may close these issues.

Failed files on first run of copy corrupt the stats of the job on resume
3 participants
@pranavmalik-msft @nakulkar-msft @vibhansa-msft