Fix PreserveSMBAttr for linux #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakulkar-msft
requested review from
gapra-msft,
adreed-msft,
siminsavani-msft,
vibhansa-msft,
tasherif-msft,
seanmcc-msft and
pranavmalik-msft
as code owners
|
point PR to dev |
vibhansa-msft
previously approved these changes
Jan 10, 2024
gapra-msft
approved these changes
Jan 10, 2024
vibhansa-msft
approved these changes
Jan 17, 2024
pranavmalik-msft
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve smb-permissions to linux was not working because of a restrictive interface. Cleaned the interface. The same tests running on windows have been made to run in linux. There is one test which fails, I'm yet to understand and I've disabled it on linux currently. Will check with Adele.