Updated thirdpartynotice file #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JohnRusk could you please review/merge? It's much easier to see the changes (without the spacing adjustments) in Codeflow. |
JohnRusk
suggested changes
Oct 10, 2019
There was a problem hiding this comment.
There are several things which we are using but which are not included in this file. We need to add them to the file. Conveniently, all are using licences that are already present in the file. they are:
cpuguy83/go-md2man
stretchr/objx
gopkg.in/ini.v1 v1.42.0
gopkg.in/yaml.v2 v2.2.2
JohnRusk
approved these changes
Oct 10, 2019
JohnRusk
added a commit
that referenced
this pull request
Oct 10, 2019
(Cherry picked to dev after PR accidently had master as base)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing dependencies from go.mod file to our third party notice file