Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure-storage-ruby 1.0.0 Release PR #109

Merged
merged 12 commits into from
Jan 12, 2018
Merged

Azure-storage-ruby 1.0.0 Release PR #109

merged 12 commits into from
Jan 12, 2018

Conversation

katmsft
Copy link
Member

@katmsft katmsft commented Jan 11, 2018

No description provided.

@coveralls
Copy link

coveralls commented Jan 11, 2018 •
edited

Coverage Status

Coverage increased (+2.6%) to 88.422% when pulling 7357aeb on katmsft:split into 381b179 on Azure:dev.

@katmsft
Resolved an issue where user tries to access Azure::Storage::Common::…
ce34338 
…Default::signer would throw undefined method 'signer' for Azure::Storage::Default:Module.
@coveralls
Copy link

coveralls commented Jan 11, 2018 •
edited

Coverage Status

Coverage increased (+2.6%) to 88.422% when pulling ce34338 on katmsft:split into 381b179 on Azure:dev.

yaxia
yaxia approved these changes Jan 11, 2018
View reviewed changes
Copy link
Member

@yaxia yaxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is too long to take a whole look. But I have looked into individual reviews. So signing off it.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.6%) to 88.437% when pulling 54c9c9a on katmsft:split into 381b179 on Azure:dev.

@coveralls
Copy link

coveralls commented Jan 12, 2018 •
edited

Coverage Status

Coverage increased (+2.6%) to 88.422% when pulling 54c9c9a on katmsft:split into 381b179 on Azure:dev.

@vinjiang vinjiang merged commit b53d436 into Azure:dev Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaxia yaxia yaxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@katmsft @coveralls @yaxia @vinjiang