Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Base64.strict_encode64 for queue message serialization #139

Merged
merged 1 commit into from Apr 23, 2019
Merged

Use Base64.strict_encode64 for queue message serialization #139

merged 1 commit into from Apr 23, 2019

Conversation

sbonebrake
Copy link

Fixes #138

@coveralls
Copy link

coveralls commented Jan 15, 2019 •
edited

Coverage Status

Coverage remained the same at 87.125% when pulling 0aa76bc on sbonebrake:queue_strict_base64 into df9c2cb on Azure:master.

@katmsft
Copy link
Member

katmsft commented Jan 16, 2019

The code looks good to me. However, can you add a test case to test the fixed issue so that it won't be a regression later? Thanks!

@sbonebrake sbonebrake force-pushed the queue_strict_base64 branch 2 times, most recently from 1a82e3e to 7b80cc2 Compare February 14, 2019 04:44
@sbonebrake
Copy link
Author

Test case force pushed to my branch

@yaxia yaxia changed the base branch from master to dev February 14, 2019 05:37
@yaxia yaxia added the bug label Apr 11, 2019
katmsft
katmsft approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@katmsft katmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinjiang vinjiang merged commit 6986c42 into Azure:dev Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaxia yaxia yaxia approved these changes

@katmsft katmsft katmsft approved these changes

Assignees

@katmsft katmsft

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sbonebrake @coveralls @katmsft @yaxia @vinjiang