Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Faraday to Version 2.0 #228

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

honeyankit
Copy link

@honeyankit honeyankit commented Apr 20, 2023

🖼️ Context

Upgrading the Faraday gem from version 1.0.0 to 2.0.

fix #227

✅ Approach

  • In the process of upgrading the faraday gem to version 2.0 from 1.0, I need to remove the faraday_middleware as it has been deprecated based on its docs and need to use the middleware faraday-follow_redirects. Details are present in the awesome-faraday docs.
  • Based on the Faraday upgrade docs, all the adapters, except for the net_http, have already been moved out and released as separate gems. So I had to add adapter faraday-net_http_persistent (gem) as part of this upgrade.

Updating faraday to version 2.0
@honeyankit honeyankit marked this pull request as ready for review April 20, 2023 23:10
@honeyankit
Copy link
Author

honeyankit commented Apr 20, 2023

I was able to do the testing with command rake test:unit --trace. First I ran with the test with the original code (ie. faraday 1.0 and faraday-middleware) then I updated the Faraday to 2.0 and removed faraday-middleware and added necessary adapters and middlewares.

Note: For the unit test, I was getting same 135 failures before as well after the upgrades during the running of the unit test (rake test:unit --trace)

@mhais22
Copy link

mhais22 commented May 5, 2023

are there plans to merge this?

@grncdr
Copy link

grncdr commented May 14, 2023

These are very similar changes to what was done on my own fork. However, I don't think anybody is really actively maintaining this Gem any more.

@serprex
Copy link

serprex commented May 24, 2023

citusdata is a Microsoft organization maintaining a fork https://github.com/citusdata/azure-storage-ruby/tree/faraday2 unfortunately when I tried looking into whether the citus team could take over maintaining this gem the email thread went nowhere

@honeyankit
Copy link
Author

honeyankit commented Jun 15, 2023

We had to create our own forks in the GitHub org and take the changes as Microsoft is not maintaining this repo anymore. I would be happy if they accept this PR, at-least for the short term it will unblock many folks.

Alternatively, folks can use the below below forked repo.
https://github.com/honeyankit/azure-storage-ruby

@honeyankit honeyankit changed the title Updating faraday to version 2.0 Upgrade Faraday to Version 2.0 Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to faraday 2.0.0
5 participants