Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for v0.11.2-preview #58

Merged
merged 3 commits into from
Oct 31, 2016
Merged

Changes for v0.11.2-preview #58

merged 3 commits into from
Oct 31, 2016

Conversation

yaxia
Copy link
Member

@yaxia yaxia commented Oct 31, 2016

ALL

  • Fixed the issue where it retries on HTTP 4xx errors.

BLOB

  • Fixed the issue of wrong "Content-Encoding". #49

@coveralls
Copy link

coveralls commented Oct 31, 2016 •
edited

Coverage Status

Coverage increased (+0.04%) to 81.166% when pulling 17a9a8c on yaxia:dev into 61c7227 on Azure:dev.

@coveralls
Copy link

coveralls commented Oct 31, 2016 •
edited

Coverage Status

Coverage increased (+0.04%) to 81.166% when pulling df3393a on yaxia:dev into 61c7227 on Azure:dev.

@coveralls
Copy link

coveralls commented Oct 31, 2016 •
edited

Coverage Status

Coverage increased (+0.04%) to 81.166% when pulling 2231cfa on yaxia:dev into 61c7227 on Azure:dev.

@yaxia yaxia mentioned this pull request Oct 31, 2016
Closed
@vinjiang vinjiang merged commit 9c95c2e into Azure:dev Oct 31, 2016
slumos
slumos reviewed Oct 31, 2016
View reviewed changes
lib/azure/storage/blob/blob_service.rb
if headers && !body.nil?
if headers['Content-Encoding'].nil?
Service::StorageService.with_header headers, 'Content-Encoding', body.encoding.to_s
if headers && !body.nil? && !(body.encoding.to_s <=> 'ASCII_8BIT')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The third condition here will never be true. In Ruby, only false and nil evaluate to false. The <=> operator returns {-1, 0, 1}.

31Oct 11:37:39 ~ 0% pry
[1] pry(main)> !('ASCII_8BIT' <=> 'ASCII_8BIT')
=> false
[2] pry(main)> !('ASCII_8BIT' <=> 'xyz')
=> false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slumos slumos slumos left review comments

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yaxia @coveralls @slumos @vinjiang @azurecla