Fix double-free throughout amqp_definitions #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericwol-msft
changed the title
vaavva
reviewed
Jan 22, 2024
| @@ -19,8 +19,8 @@ namespace amqplib_generator | |||
| /// Class to produce the template output | |||
| /// </summary> | |||
|
|
|||
| #line 1 "g:\repos\azure-event-hubs-c\deps\azure-uamqp-c\uamqp_generator\amqp_definitions_c.tt" | |||
| [global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.VisualStudio.TextTemplating", "15.0.0.0")] | |||
| #line 1 "C:\code\s1\azure-uamqp-c\uamqp_generator\amqp_definitions_c.tt" | |||
There was a problem hiding this comment.
Did this get changed to your local path?
There was a problem hiding this comment.
Yes, that's normal for the amqp_definitions. Whoever updates it most recently gets those paths updated to their local paths. The VS text-template engine does that automatically.
ericwol-msft
approved these changes
Jan 22, 2024
This is related to issue 84965 (work item 186232). The bugs identified in open_get_offered_capabilities are correct. open_get_offered_capabilities is implemented in amqp_definitions.c, which is autogenerated from amqp_definitions_c.tt. amqp_definitions_c.tt is also used to autogerate functions for other AMQP composite types. By fixing amqp_definitions_c.tt (function in lines 317 to 494) this double-free bug pattern is being addressed for: - open_get_outgoing_locales - open_get_incoming_locales - open_get_offered_capabilities - open_get_desired_capabilities - begin_get_offered_capabilities - begin_get_desired_capabilities - attach_get_offered_capabilities - attach_get_desired_capabilities - sasl_mechanisms_get_sasl_server_mechanisms - source_get_outcomes - source_get_capabilities - target_get_capabilities
ewertons
force-pushed
the
ewertons/MSRC84965
branch
from
d5e9368
to
a9d2648
Compare
vaavva
approved these changes
Jan 22, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue 84965 (work item 186232).
The bugs identified in open_get_offered_capabilities are correct. open_get_offered_capabilities is implemented in amqp_definitions.c, which is autogenerated from amqp_definitions_c.tt. amqp_definitions_c.tt is also used to autogerate functions for other AMQP composite types. By fixing amqp_definitions_c.tt (function in lines 317 to 494) this double-free bug pattern is being addressed for: