Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to provide start date time for cosmos feed start #691

Merged
merged 20 commits into from
Feb 26, 2021

Conversation

adityavaish
Copy link
Contributor

@adityavaish adityavaish commented Nov 25, 2020

Exposing StartTime of ChangeFeedProcessorOptions to client attribute so that a client to specify the start point of the feed. The date time should ideally be in UTC but it can take any format that can be parsed by C# DateTime

Added default test case to check the added attribute.

@net-foundation-cla
Copy link

net-foundation-cla bot commented Nov 25, 2020

CLA assistant check
All CLA requirements met.

@adityavaish adityavaish marked this pull request as ready for review November 25, 2020 22:57
Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brettsam Do we have any other trigger that passes datetime information? What is the recommendation on the format?

@adityavaish
Copy link
Contributor Author

A gentle ping on the review!

@adityavaish
Copy link
Contributor Author

@fabiocav @brettsam - please help review

adityavaish and others added 9 commits January 20, 2021 14:12
…te.cs

Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>
…teBindingProvider.cs

Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>
…teBindingProvider.cs

Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>
@fabiocav fabiocav added this to the Functions Sprint 94 milestone Jan 20, 2021
@brettsam
Copy link
Member

@brettsam Do we have any other trigger that passes datetime information? What is the recommendation on the format?

I don't think we do -- I was just trying to think through that as well. I know we have some that use TimeSpan, let me double-check how we handle that.

@ealsur
Copy link
Member

ealsur commented Feb 11, 2021

My concern is more around other languages, if the ISO format would work fine for them or there is a different one. Otherwise I see no blockers on the PR other than the test gap at this point.

@Azure Azure deleted a comment from adityavaish Feb 16, 2021
Copy link
Member

@brettsam brettsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one other comment that I can't directly link to (and maybe it can be an immediate follow-up PR by @ealsur?) -- but now that the parsing of attribute strings can have some interesting side effects (time zones...), it may be good to explicitly log the fully-resolved ProcessorOptions with a _logger.LogDebug(...) statement here: https://github.com/Azure/azure-webjobs-sdk-extensions/blob/dev/src/WebJobs.Extensions.CosmosDB/Trigger/CosmosDBTriggerListener.cs#L129. That would help immensely when trying to support folks that may have configured something slightly incorrectly.

Deserialization of chunked requests does not work (Issue Azure#702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants