Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos DB] Rename ConnectionStringSetting and collection #733

Merged
merged 6 commits into from
Aug 3, 2021

Conversation

ealsur
Copy link
Member

@ealsur ealsur commented Aug 2, 2021

Other extensions are using the name Connection for attribute mapping that works for connection strings (example https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/eventhub/Microsoft.Azure.WebJobs.Extensions.EventHubs/src/EventHubAttribute.cs#L33) but would also work for AAD information.

Since we are already on a breaking change train (moving to V3 SDK), might as well rename it to be consistent (anyway, using ConnectionStringSetting would not sound great for AAD).

As part of the naming alignment, V3 SDK documentation talks about Containers, not Collections anymore, so the property names like CollectionName are renamed to ContainerName.

@ealsur ealsur requested a review from brettsam August 2, 2021 22:39
@ealsur ealsur requested a review from fabiocav August 2, 2021 23:03
@fabiocav
Copy link
Member

fabiocav commented Aug 3, 2021

@ealsur looks good. As long as this is going in a new major version.

Thanks for sending refactoring work like this as a standalone PR!

@ealsur ealsur merged commit 1ba3588 into Azure:dev Aug 3, 2021
@ealsur ealsur deleted the users/ealsur/cosmosaad branch August 3, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants