Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos DB - Add Support for AAD authentication #736

Merged
merged 9 commits into from
Aug 25, 2021

Conversation

ealsur
Copy link
Member

@ealsur ealsur commented Aug 11, 2021

This PR expands the support for authentication to include AAD.

Users can define on the Cosmos DB Trigger or binding a Connection value that points to a configuration that either:

  • Is a string and represents a valid Cosmos DB Connection String
{
        "MyConnection": "<cosmos db connection string>"
}
  • Is a JSON node with valid AAD information:
{
	"MyConnection" : {
             "accountEndpoint": "https://myCosmosDBaccount.documents.azure.com:443/",
	     "clientId": "AAD client Id",
	     "tenantId": "AAD Tenant Id",
	     "clientSecret": "AAD secret"
       }
}

@ealsur ealsur requested a review from brettsam August 12, 2021 01:39
@brettsam
Copy link
Member

A couple of minor comments....

@pakrym
Copy link

pakrym commented Aug 25, 2021

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants