Cosmos DB - AddAzureClientsCore should be called during registration #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettsam
reviewed
Sep 2, 2021
src/WebJobs.Extensions.CosmosDB/Config/CosmosDBWebJobsBuilderExtensions.cs
Show resolved
Hide resolved
brettsam
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current preview build expects users to register and call
AddAzureClientsCoreduring webjob initialization, this can be moved to be part of the Cosmos DB Extension registration.We also detected that binding types
int?do not work on runtime.And if a user was trying to customize the
ICosmosDBSerializerFactory, current code was only working if the customization happened after theAddCosmosDBcall because we were registering the default implementation withAddSingletoninstead ofTryAddSingleton, the tests did not catch it because the order on which they were written. The PR contains the fix plus new test coverage.Closes #741
Closes #743