Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disallow injecting proxy sidecar in pods with hostNetwork: true #1090

Merged
merged 2 commits into from Aug 23, 2023
Merged

fix: disallow injecting proxy sidecar in pods with hostNetwork: true #1090

merged 2 commits into from Aug 23, 2023

Conversation

aramase
Copy link
Member

@aramase aramase commented Aug 23, 2023

  • disallow injecting proxy sidecar in pods with hostNetwork: true
  • add a note about it in known issues

@aramase
fix: disallow injecting proxy sidecar in pods with hostNetwork: true
fbb36fe 
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase
docs: add proxy sidecar limitation with hostNetwork
f533999 
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase requested a review from enj as a code owner August 23, 2023 18:04
@codecov-commenter
Copy link

Codecov Report

Merging #1090 (f533999) into main (b68e331) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
+ Coverage   53.71%   53.89%   +0.18%     
==========================================
  Files          36       36              
  Lines        2290     2297       +7     
==========================================
+ Hits         1230     1238       +8     
  Misses       1014     1014              
+ Partials       46       45       -1
Files Changed Coverage Δ
pkg/webhook/webhook.go 80.06% <100.00%> (+0.77%) ⬆️

@aramase aramase requested a review from sozercan August 23, 2023 18:16
@aramase aramase enabled auto-merge (squash) August 23, 2023 18:44
sozercan
sozercan approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aramase aramase merged commit 4a889b7 into Azure:main Aug 23, 2023
22 checks passed
@aramase aramase deleted the aramase/f/disallow_host_network branch August 23, 2023 23:11
@aramase aramase mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sozercan sozercan sozercan approved these changes

@enj enj Awaiting requested review from enj enj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aramase @codecov-commenter @sozercan