Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add govulncheck check and fix GO-2024-2687 #1320

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

aramase
Copy link
Member

@aramase aramase commented Apr 10, 2024

  • add govulncheck pr gate
  • bump golang.org/x/net to v0.23.0+ to fix GO-2024-2687

@aramase aramase requested a review from enj as a code owner April 10, 2024 18:19
@aramase aramase changed the title Aramase/ci/add govuln check ci: add govulncheck check and fix GO-2024-2687 Apr 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.90%. Comparing base (3874533) to head (78f5082).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
+ Coverage   51.66%   52.90%   +1.23%     
==========================================
  Files          53       53              
  Lines        2938     2429     -509     
==========================================
- Hits         1518     1285     -233     
+ Misses       1378     1102     -276     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/ci/add_govuln_check branch from f2233fe to 78f5082 Compare April 15, 2024 22:55
@aramase aramase requested a review from sozercan April 15, 2024 22:57
@aramase aramase enabled auto-merge (squash) April 15, 2024 22:57
@aramase aramase self-assigned this Apr 16, 2024
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@aramase aramase merged commit 8885a64 into Azure:main Apr 16, 2024
23 checks passed
@aramase aramase deleted the aramase/ci/add_govuln_check branch April 16, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants