Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add Azure Portal UI steps and screenshot #374

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

arsenvlad
Copy link
Contributor

@arsenvlad arsenvlad commented Feb 17, 2022

Reason for Change:
The current version of the https://azure.github.io/azure-workload-identity/docs/topics/federated-identity-credential.html has "Coming soon" in the "Azure Portal UI" section. This change adds the steps and a screenshot.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@arsenvlad arsenvlad changed the title Add Azure Portal UI steps and screenshot fix(docs): add Azure Portal UI steps and screenshot Feb 17, 2022
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 🎉

Copy link
Contributor

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@chewong chewong merged commit 306abde into Azure:main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants