Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add msal-java example #375

Merged
merged 2 commits into from
Feb 17, 2022
Merged

feat: add msal-java example #375

merged 2 commits into from
Feb 17, 2022

Conversation

chewong
Copy link
Contributor

@chewong chewong commented Feb 17, 2022

Reason for Change:

Fixes part of #137.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@chewong chewong temporarily deployed to azwi-e2e February 17, 2022 17:58 Inactive
@chewong chewong temporarily deployed to azwi-e2e February 17, 2022 18:02 Inactive
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
@chewong chewong temporarily deployed to azwi-e2e February 17, 2022 18:04 Inactive
@chewong
Copy link
Contributor Author

chewong commented Feb 17, 2022

Feel free to ignore the CI error from markdown-link-check since github.com/Azure/azure-workload-identity/tree/main/examples/msal-java won't be available until this PR is merged.

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nit!

examples/msal-java/pom.xml Outdated Show resolved Hide resolved
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
@chewong chewong temporarily deployed to azwi-e2e February 17, 2022 18:36 Inactive
@chewong chewong merged commit 2618ac4 into Azure:main Feb 17, 2022
@chewong chewong deleted the msal-java branch February 17, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants