ci: use pull_request instead of pull_request_target for Actions #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewong
commented
Feb 23, 2022
| echo ${{ secrets.SERVICE_ACCOUNT_SIGNING_KEY }} | base64 -d > sa.key | ||
| echo ${{ secrets.SERVICE_ACCOUNT_KEY }} | base64 -d > sa.pub | ||
| openssl genrsa -out sa.key 2048 | ||
| openssl rsa -in sa.key -pubout -out sa.pub | ||
| make kind-create | ||
| - name: Build azwi | ||
| run: make bin/azwi | ||
| - uses: azure/login@v1.4.3 |
There was a problem hiding this comment.
Looks like ACTIONS_ID_TOKEN_REQUEST_URL and ACTIONS_ID_TOKEN_REQUEST_TOKEN won't be available to this action until it's merged to the main branch, which is why azure cli login failed. Let's ignore and I will open a follow-up PR to fix the CI failure.
aramase
reviewed
Feb 23, 2022
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com>
aramase
approved these changes
Feb 23, 2022
There was a problem hiding this comment.
lgtm
CI failure will resolve after the follow-up PR: #380 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Uses
pull_requestinstead ofpull_request_targetto prevent malicious commits.Requirements
Issue Fixed:
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: