chore: switch to upstream acr #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sozercan
reviewed
Mar 21, 2022
Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Ernest Wong <chuwon@microsoft.com>
aramase
approved these changes
Mar 22, 2022
chewong
commented
Mar 22, 2022
| @@ -40,11 +40,6 @@ create_cluster() { | |||
|
|
|||
| if [[ "${REGISTRY}" =~ \.azurecr\.io ]]; then | |||
| az acr login --name "${REGISTRY}" | |||
| echo "Granting AcrPull permission to the cluster's managed identity" | |||
There was a problem hiding this comment.
we have anonymous pull enabled for the upstream registry so we don't need to grant AcrPull permission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Switching staging registry from using upstreamk8sci to upstream.
Requirements
Issue Fixed:
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: