Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary rbac permissions for mwh #782

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

aramase
Copy link
Member

@aramase aramase commented Mar 7, 2023

Reason for Change:

  • Remove CREATE, PATCH, UPDATE for service accounts
  • Remove CREATE, PATCH and DELETE for mutating webhook configuration

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase changed the title fix: remove unnecessary rbac roles for mwh fix: remove unnecessary rbac permissions for mwh Mar 8, 2023
@aramase aramase force-pushed the aramase/f/trim_down_rbac_permissions branch 3 times, most recently from 1f24f37 to 8338491 Compare March 8, 2023 06:07
@aramase aramase requested a review from enj March 8, 2023 06:57
config/rbac/role.yaml Outdated Show resolved Hide resolved
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/f/trim_down_rbac_permissions branch from 8338491 to e928a63 Compare March 8, 2023 17:25
@aramase aramase requested a review from enj March 8, 2023 17:26
@aramase aramase enabled auto-merge (squash) March 8, 2023 17:37
@aramase aramase merged commit 8a7e5b3 into Azure:main Mar 8, 2023
@aramase aramase deleted the aramase/f/trim_down_rbac_permissions branch March 8, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants