Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set reinvocationPolicy: IfNeeded for webhook #794

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

aramase
Copy link
Member

@aramase aramase commented Mar 15, 2023

Reason for Change:

  • Sets reinvocationPolicy: IfNeeded for the workload identity mutating webhook.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #787
fixes #791

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

  • Validated this with the dapr extension.

@aramase aramase force-pushed the aramase/f/reinvocation_policy branch from a7f622e to efcbd37 Compare March 15, 2023 20:35
@aramase aramase requested a review from enj March 15, 2023 20:35
@aramase aramase marked this pull request as ready for review March 15, 2023 20:35
@aramase aramase enabled auto-merge (squash) March 15, 2023 20:40
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/f/reinvocation_policy branch from efcbd37 to 803f6a4 Compare March 15, 2023 21:14
@aramase aramase merged commit a2c807b into Azure:main Mar 15, 2023
@aramase aramase deleted the aramase/f/reinvocation_policy branch March 15, 2023 22:26
@berndverst
Copy link

Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants