Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make podDisruptionBudget minAvailable/maxUnavailable configurable #827

Merged
merged 1 commit into from Apr 13, 2023

Conversation

aramase
Copy link
Member

@aramase aramase commented Apr 6, 2023

fixes #824

@aramase aramase force-pushed the aramase/f/helm_pdb_configurable branch from 5e85eeb to b4bd474 Compare April 12, 2023 00:18
Copy link
Member

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but how exactly do we test that it works?

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/f/helm_pdb_configurable branch from b4bd474 to 2437fed Compare April 12, 2023 19:42
@aramase
Copy link
Member Author

aramase commented Apr 13, 2023

This LGTM but how exactly do we test that it works?

With this PR, we're only changing the default value to be customizable. We can try to add a drain test (if possible) with #826 to validate this behavior.

@aramase aramase merged commit a04974d into Azure:main Apr 13, 2023
19 checks passed
@aramase aramase deleted the aramase/f/helm_pdb_configurable branch April 13, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure-wi-webhook-controller-manager brokes aks upgrade because of pdb
2 participants