This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Test runs no longer delete credentials. #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also consolidated the three different but otherwise identical credential store tests into a single file that tests all three options (if the tests can run, that is).
|
LGTUS. Reviewed by the team. |
amarzavery
added a commit
that referenced
this pull request
Oct 22, 2014
Test runs no longer delete credentials.
| } | ||
|
|
||
| function isOsx() { | ||
| return os.platform() === 'darwin'; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also consolidated the three different but otherwise identical
credential store tests into a single file that tests all three
options (if the tests can run, that is).
Figured this would be useful when running final tests passes as without this change the test run blows away the logged in user's access tokens in the middle of the run.