Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Fix issue #2102 and #2103 #2104

Merged
merged 3 commits into from Sep 17, 2015
Merged

Fix issue #2102 and #2103 #2104

merged 3 commits into from Sep 17, 2015

Conversation

yaxia
Copy link
Member

@yaxia yaxia commented Sep 15, 2015

  1. Fix the issue that it reports: Cannot read property 'substr' of null when user doesn't login or no endpoint is provided.
  2. Modify the build script as the npm.zip is only available in https address now.

@azurecla
Copy link

Hi @yaxia, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (yaxia). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

set NODE_DOWNLOAD_URL=http://nodejs.org/dist/v%NODE_VERSION%/node.exe
set NPM_DOWNLOAD_URL=http://nodejs.org/dist/npm/npm-%NPM_VERSION%.zip
set NODE_DOWNLOAD_URL=https://nodejs.org/dist/v%NODE_VERSION%/node.exe
set NPM_DOWNLOAD_URL=https://nodejs.org/dist/npm/npm-%NPM_VERSION%.zip
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I change it is that at the day Node.js 4.0 was released, this npm cannot be downloaded from this address and the server returned HTTP 301 (Moved Permanently), only HTTPS worked. It looks like the address works again now, but I am not sure whether it will be inaccessible again.

yugangw-msft added a commit that referenced this pull request Sep 17, 2015
@yugangw-msft yugangw-msft merged commit 2cfa197 into Azure:dev Sep 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants