This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Add mac hash to user agent header #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
header, per VS Telemetry standard.
.. mac address is sent in user agent header.
as their mac addresses
.. definitions as we're not on ES6. Thank you, jslint.
amarzavery
approved these changes
Feb 23, 2017
| var interfaceKeys = Object.keys(networkInterfaces); | ||
|
|
||
| var nicPattern; | ||
| if (os.platform().startsWith('win')) { |
There was a problem hiding this comment.
os.platform() does not return a string, it's an object!
There was a problem hiding this comment.
Not sure where you're seeing its an object.
But looking at https://nodejs.org/api/os.html#os_os_platform
os.platform()
Added in: v0.5.0
Returns: <string>
Currently possible values are:
'aix'
'darwin'
'freebsd'
'linux'
'openbsd'
'sunos'
'win32'
|
It's making azure-cli unusable, crashes at every command. See issue #3546
… On 24 Mar 2017, at 17:32, Balaji Krishnan ***@***.***> wrote:
@balajikris commented on this pull request.
In lib/util/telemetry.js:
> };
}
}
+
+
+var _getMacAddressHash = function () {
+ var networkInterfaces = os.networkInterfaces();
+ var interfaceKeys = Object.keys(networkInterfaces);
+
+ var nicPattern;
+ if (os.platform().startsWith('win')) {
Not sure where you're seeing its an object.
But looking at https://nodejs.org/api/os.html#os_os_platform
os.platform()
Added in: v0.5.0
Returns: <string>
Currently possible values are:
'aix'
'darwin'
'freebsd'
'linux'
'openbsd'
'sunos'
'win32'
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
yep, noticed the bug after i responded to this comment. I've responded to the bug now. Check it out and let me know if it worked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content to be added to Changelog is as follows: