This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Improved Network DNS Zone Import's data validation #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improved counter for record set import (now it additionally shows number of successful imports) * Fixed convertToFQDN function (now correctly processes names with trailing "." and ".@")
* Added name & token validation * Changed import progress output message * Re-recorded unit tests
|
@number213 has it been tested by Jonathan? |
|
LGTM |
|
@MikhailTryakhov I've uploaded changes to his VM but he hasn't replied to me yet. I've pinged him today. |
|
I tried the shared VM, everything worked perfectly! Please ship it :) |
balajikris
approved these changes
Apr 25, 2017
|
Thanks everyone. Thanks @jtuliani and @MikhailTryakhov for testing and reviewing the changes! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[AGE:xxxxxx]that make DNS zone list input invaliddns zone importprogress' outputThe content to be added to Changelog is as follows: