Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users/anksing/release 1.5.0 #2140

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Users/anksing/release 1.5.0 #2140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec70378
Update share-models-components-environments.ipynb
singankit Mar 20, 2023
68b7b5c
Update online-endpoints-keyvault.ipynb
singankit Mar 20, 2023
7fc19f1
Update share-models-components-environments.ipynb
singankit Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions sdk/python/assets/assets-in-registry/share-models-components-environments.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,11 +399,14 @@
" name=\"nyc-taxi-model\", version=version\n",
")\n",
"print(\"workspace model:\\n\\n\", model_in_workspace)\n",
"# change the format such that the registry understands the model (when you print the model_ready_to_copy object, notice the asset id\n",
"model_ready_to_copy = ml_client_workspace.models._prepare_to_copy(model_in_workspace)\n",
"print(\"\\n\\nmodel ready to copy:\\n\\n\", model_ready_to_copy)\n",
"# copy the model from registry to workspace\n",
"ml_client_registry.models.create_or_update(model_ready_to_copy).wait()"
"# share the model from registry to workspace\n",
"ml_client_workspace.models.share(\n",
" name=\"nyc-taxi-model\",\n",
" version=version,\n",
" registry=\"<registry-name>\",\n",
" share_with_name=\"nyc-taxi-model-new\",\n",
" share_with_version=version,\n",
")"
]
},
{
Expand Down Expand Up @@ -598,11 +601,6 @@
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.8.8"
},
"vscode": {
"interpreter": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this delete expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests passed with when this change came in so guessing should be okay.

"hash": "cb451b1acfd48ceac5a931ea70033c1eb64868bd3ea755a5c8b8f7161e90ef7b"
}
}
},
"nbformat": 4,
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/endpoints/online/managed/online-endpoints-keyvault.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@
" location=endpoint.location,\n",
" properties=VaultProperties(\n",
" tenant_id=endpoint.identity.tenant_id,\n",
" sku=Sku(name=\"Standard\"),\n",
" sku=Sku(name=\"Standard\", family=\"A\"),\n",
" access_policies=[endpoint_access_policy, user_or_sp_access_policy],\n",
" ),\n",
" ),\n",
Expand Down