Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating model import component limitations #2295

Merged
merged 1 commit into from
May 19, 2023

Conversation

ShipraJain01
Copy link
Contributor

Description

updating model import component limitations. Changes in 'import_model_into_registry.ipynb' and adding new 'requirements.txt' file

Checklist

Copy link
Contributor

@ManojBableshwar ManojBableshwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do some wordsmithing but can get that post //build. the changes look good to me.

About additional packages, i have noticed that these are the additional packages needed for top 1000 models on HF

  • You need to install sacremoses to use XLMTokenizer and BioGptTokenizer
  • You need to install fugashi to use MecabTokenizer
  • google-tapas-small-finetuned-wtq requires the torch-scatter library

@ShipraJain01
Copy link
Contributor Author

we can do some wordsmithing but can get that post //build. the changes look good to me.

About additional packages, i have noticed that these are the additional packages needed for top 1000 models on HF

  • You need to install sacremoses to use XLMTokenizer and BioGptTokenizer
  • You need to install fugashi to use MecabTokenizer
  • google-tapas-small-finetuned-wtq requires the torch-scatter library

hi @ManojBableshwar
Could you please share pinned version of these dependencies. Also these dependencies are coming from azureml-evaluate-mlflow and Model Import package. If we want to add additional dependencies, we will have to rebuild environments and do a fresh py-pi release. Do we need that now?

@ManojBableshwar
Copy link
Contributor

the above packages impact a tiny percentage of models. pls log a task to revisit this post build

@skasturi skasturi merged commit bc1f1dd into main May 19, 2023
7 checks passed
@skasturi skasturi deleted the shiprajain/modelimportlimitations branch May 19, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants