Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix when the job fails and doesn't kick the node #3186

Merged
merged 2 commits into from
May 13, 2024
Merged

fix when the job fails and doesn't kick the node #3186

merged 2 commits into from
May 13, 2024

Conversation

cassieesvelt
Copy link
Contributor

Description

Job wasn't failing when node kicking was set to false. Fixed

Checklist

  • I have read the contribution guidelines.
  • I have coordinated with the docs team (mldocs@microsoft.com) if this PR deletes files or changes any file names or file extensions.
  • Pull request includes test coverage for the included changes.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

@cassieesvelt cassieesvelt merged commit 93bb9a8 into main May 13, 2024
4 checks passed
@cassieesvelt cassieesvelt deleted the cesvet/nhc-fix-job-fail-case branch May 13, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitamittal1 savitamittal1 savitamittal1 approved these changes

@sanchez-alex sanchez-alex sanchez-alex approved these changes

@hakotesova hakotesova hakotesova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cassieesvelt @savitamittal1 @sanchez-alex @hakotesova