Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Add Batch environment variables to pool start task #252

Closed
jackpimbert opened this issue Dec 20, 2018 · 4 comments
Closed

Add Batch environment variables to pool start task #252

jackpimbert opened this issue Dec 20, 2018 · 4 comments
Labels

Comments

@jackpimbert
Copy link
Contributor

jackpimbert commented Dec 20, 2018

Feature Request Description

I would like to use the Azure batch insights to get some simple monitoring information via the Batch Explorer. To do so looks fairly straight forward, however I need to add some Batch environment variables that can be seen on start of a vm in a pool, and also from Batch Explorer. Therefore, using export isn't enough and instead the environment variables need to be added within the start task, e.g.

batch-shipyard/convoy/fleet.py

Lines 1520 to 1523 in 296c39b

environment_settings=[
batchmodels.EnvironmentSetting(
name='LC_ALL', value='en_US.UTF-8'),
],

Describe Preferred Solution

An option in the pool configuration to add custom environment variables, as is possible within the jobs configuration.

Please let me know if there's another way of adding environment variables to the start task, such that they will be included as Batch environment variables and seen within the Batch Explorer, thanks!

@alfpark alfpark changed the title Add Batch environment variables to pool on start Add Batch environment variables to pool start task Jan 15, 2019
@alfpark
Copy link
Collaborator

alfpark commented Jan 15, 2019

Would it be helpful to provide direct Batch App Insights integration? This was on my backlog but instead opted for a full Prometheus/Grafana monitoring solution that aligns with an open source solution providing container-level metrics.

@jackpimbert
Copy link
Contributor Author

I would find it useful as a lighter weight monitoring solution in comparison to using Prometheus/Grafana. In our current use case it works better, although we may end up going for the full solution in the future.

@jackpimbert
Copy link
Contributor Author

Should I close this issue now that #253 has been merged in?

@alfpark
Copy link
Collaborator

alfpark commented Jan 16, 2019

The issue will auto-close when the commit is merged to master.

The Batch Insights integration has been merged to develop in #259.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants