Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: API Management Module should add the creation of 'Microsoft.ApiManagement/service/loggers' and 'Microsoft.ApiManagement/service/apis/diagnostics' #1124

Closed
1 task done
Menghua1 opened this issue Mar 5, 2024 · 6 comments · Fixed by #2453
Assignees
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@Menghua1
Copy link
Member

Menghua1 commented Mar 5, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/api-management/service

(Optional) Module Name if not listed above

avm/res/api-management/service

(Optional) Module Version

No response

Description

Please add the creation of Microsoft.ApiManagement/service/loggers and Microsoft.ApiManagement/service/apis/diagnostics.
For example (azd):
https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/gateway/apim.bicep#L61
https://github.com/Azure-Samples/todo-java-mongo/blob/main/infra/app/apim-api.bicep#L56

CC: @jongio

(Optional) Correlation Id

No response

@Menghua1 Menghua1 added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 5, 2024
@github-actions github-actions bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

@Menghua1, thanks for submitting this issue for the avm/res/api-management/service module!

A member of the @azure/avm-res-apimanagement-service-module-owners-bicep or @azure/avm-res-apimanagement-service-module-contributors-bicep team will review it soon!

@github-actions github-actions bot added the Class: Resource Module 📦 This is a resource module label Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

This issue couldn't be assigend due to an internal error. @tony-box, please make sure this issue is assigned to you and please provide an initial response within 5 business days.

@tony-box tony-box self-assigned this Mar 5, 2024
@tony-box
Copy link
Contributor

tony-box commented Mar 5, 2024

Assigning to myself due to issue with auto group assignment.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Mar 11, 2024
@AlexanderSehr AlexanderSehr removed Needs: Triage 🔍 Maintainers need to triage still Needs: Attention 👋 Reply has been added to issue, maintainer to review Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Mar 11, 2024
@jongio
Copy link
Member

jongio commented Mar 25, 2024

@tony-box - Do you have an ETA for this?

Note

The "Type: AVM 🅰️ ✌️ Ⓜ️" label was added as per ITA08BCP.

@Menghua1 Menghua1 changed the title [AVM Module Issue]: API Management Module should add the creation of 'Microsoft.ApiManagement/service/loggers' [AVM Module Issue]: API Management Module should add the creation of 'Microsoft.ApiManagement/service/loggers' and 'Microsoft.ApiManagement/service/apis/diagnostics' Mar 29, 2024
@v-xuto
Copy link
Member

v-xuto commented Jun 18, 2024

This issue is fixing by pr: #2453.

hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this issue Jun 19, 2024
## Description

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes Azure#123
Fixes Azure#456
Closes Azure#123
Closes Azure#456
-->

Closes Azure#2075 
Closes Azure#1929 
Closes Azure#1124 
Closes Azure#1104 
Closes Azure#2362 
Closes Azure#2444 

Big update v0.2 release:

- update all APIM apis to newer versions
- new feat: Add PublicIP
- new feat: add API Loggers
- new feat: add API Diagnostics
- new feat: add v2sku options
- add test case for v2sku
- updates to many default params to better align with PSRule suggestions
for better reliability and security

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.api-management.service](https://github.com/tony-box/bicep-registry-modules/actions/workflows/avm.res.api-management.service.yml/badge.svg?branch=v0.2)](https://github.com/tony-box/bicep-registry-modules/actions/workflows/avm.res.api-management.service.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [x] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [x] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Tony Box <tobox@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment