[AVM Module Issue]: compute/virtual-machine and name of OSDisk and DataDisk partly hardcoded in main.bicep

[aavdberg]

Check for previous/existing GitHub issues

• I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/compute/virtual-machine

(Optional) Module Name if not listed above

No response

(Optional) Module Version

No response

Description

When I want to use the module in existing pipeline and with existing resources i have the problem with OSDisk and Datadisk name are hardcoded in the bicep file.

and they are not to be changed on existing resources.

So you have to have the possibility to configure them with parameters.

(Optional) Correlation Id

No response

[microsoft-github-policy-service]

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Note

This label was added as per ITA06.

[microsoft-github-policy-service]

Note

The "Type: Bug 🐛" label was added as per ITA21.

[github-actions]

@aavdberg, thanks for submitting this issue for the avm/res/compute/virtual-machine module!

A member of the @azure/avm-res-compute-virtualmachine-module-owners-bicep or @azure/avm-res-compute-virtualmachine-module-contributors-bicep team will review it soon!

[johnlokerse]

@AlexanderSehr @rahalan Can you assign this issue to me? I can pick this up.

[AlexanderSehr]

Hey @johnlokerse, done - thank you very much :)

cc: @rahalan

[rahalan]

@johnlokerse please see PR #1515 . There I did something similar for the NIC name.

[johnlokerse]

Thanks for the tip @rahalan! I have done something similar: https://github.com/johnlokerse/bicep-registry-modules/blob/johnlokerse/issue1436/avm/res/compute/virtual-machine/main.bicep#L478

Only need to run some tests before creating the PR.

[johnlokerse]

Opened PR #1517