feat: Added UDTs for disks and ability to give a custom name to a disk - avm/res/compute/virtual-machine
#1517
Conversation
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
|
While running tests I got this error which I can't place. It looks good to me, name is optional and it is checked with coalesce and it still expecting the 
|
matebarabas
added
Class: Resource Module 📦
avm/res/compute/virtual-machine/tests/e2e/windows.nvidia/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/compute/virtual-machine/tests/e2e/windows.nvidia/main.test.bicep
Outdated
Show resolved
Hide resolved
|
Implemented PR feedback. Running Actions for tests now. @rahalan Yesterday I had a capacity error for the Nvidia test. What region do you suggest to set when I get this error again? |
You can't. Just ignore the test. To get it running you need to ask for a quota of the VM type. |
Ok will do! @AlexanderSehr @rahalan How do we deal with key vaults that already exist somewhere in the Azure world? Deployment name could be used with a unique string. 
|
|
@johnlokerse because of that e have the TOKEN_NAMEPREFIX. Maybe try a different one. |
|
Green workflow (except for Nvidia): It didn't include the static validation step because I replaced the value of Would you like me to wait until the key vault can be redeployed and I can run all the steps for a green workflow? |
|
@johnlokerse regarding the nameprefix: the name prefix needs to be a secret in your GH, see 3.1 https://azure.github.io/Azure-Verified-Modules/contributing/bicep/bicep-contribution-flow/#31-set-up-secrets |
@rahalan Oh right completely forgot about that... will run the tests with updated prefix tomorrow. FYI; Also need to revert the backup service guid |
avm/res/compute/virtual-machine/tests/e2e/windows.nvidia/main.test.bicep
Show resolved
Hide resolved
| @@ -24,6 +24,10 @@ param password string = newGuid() | |||
| @description('Optional. A token to inject into the name of each resource.') | |||
| param namePrefix string = '#_namePrefix_#' | |||
|
|
|||
| // Set to fixed location as the RP function returns unsupported locations | |||
| // Right now (2024/04) the following locations are supported: centralindia,uksouth,ukwest,japaneast,australiaeast,canadaeast,canadacentral,northeurope,westeurope,eastus,eastus2,westus,westus2,westus3,northcentralus,southcentralus,westcentralus,centralus | |||
| param enforcedLocation string = 'westeurope' | |||
There was a problem hiding this comment.
@rahalan we should not use West Europe. Please change in your next PR
| @@ -20,6 +20,10 @@ param serviceShort string = 'cvmlinatmg' | |||
| @description('Optional. A token to inject into the name of each resource.') | |||
| param namePrefix string = '#_namePrefix_#' | |||
|
|
|||
| // Set to fixed location as the RP function returns unsupported locations (configurationProfileAssignments) | |||
| // Right now (2024/04) the following locations are supported: centralus, eastus, eastus2, southcentralus, westus, westus2, westcentralus, northeurope, westeurope, canadacentral, japaneast, uksouth, australiasoutheast, australiaeast, southeastasia, westus3 | |||
| param enforcedLocation string = 'westeurope' | |||
There was a problem hiding this comment.
@rahalan we should not use West Europe. Please change in your next PR
There was a problem hiding this comment.
@AlexanderSehr Are there any guidelines on what region must be used in this situation?
There was a problem hiding this comment.
@AlexanderSehr In other Bicep templates the enforcedLocation variable is scoped to either eastus or eastasia. So eastus would be the choice here. Is that correct?
avm/res/compute/virtual-machine/tests/e2e/windows.nvidia/main.test.bicep
Show resolved
Hide resolved
avm/res/compute/virtual-machine/tests/e2e/windows.max/dependencies.bicep
Show resolved
Hide resolved
avm/res/compute/virtual-machine/tests/e2e/waf-aligned/dependencies.bicep
Show resolved
Hide resolved
|
Hey @johnlokerse, I could help but also take a peak as I was mentioned in a comment (as per my notifications). Commented a couple other things aside the GUID that you already mentioned that I'd suggest to change/fix soon. |
|
@AlexanderSehr @rahalan Yes I will pick this up, will be my first thing to do tomorrow! Didn't expect a merge this quick, so my bad. |
|
@johnlokerse @AlexanderSehr I didn't review good enough, my bad. I will change the GUID back to the correct one in my already open PR |
…k - `avm/res/compute/virtual-machine` (Azure#1517) ## Description This pull request adds UDTs for OS disk and data disk. Also, included the option to give a custom name to either disk. ## Pipeline Reference | Pipeline | | -------- | | [](https://github.com/johnlokerse/bicep-registry-modules/actions/workflows/avm.res.compute.virtual-machine.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [ ] I'm sure there are no other open Pull Requests for the same update/change - [ ] I have run `Set-AVMModule` locally to generate the supporting module files. - [ ] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Rainer Halanek <61878316+rahalan@users.noreply.github.com>
…mit messages in this repository: 1. added readme 2. feat: Added UDTs for disks and ability to give a custom name to a disk - `avm/res/compute/virtual-machine` (Azure#1517) 3. Merge branch 'Azure:main' into avm-ptn-alz-sub-vending 4. fix: Dnsrule bug for virtual Network link name (Azure#1538) 5. fix: prevent updating the workspace repository configuration whenever no value is provided, so an existing configuration is not overwritten. (Azure#1680) 6. fix: WAF reliability and static validation in `avm/res/web/site` (Azure#1427) 7. fix: Update for default WAF-alignment - `avm/res/cache/redis` (Azure#1621) 8. Merge branch 'Azure:main' into avm-ptn-alz-sub-vending 9. fix: pwsh publish module index (Azure#1683) 10. feat: Added UDTs for disks and ability to give a custom name to a disk - `avm/res/compute/virtual-machine` (Azure#1517)
](https://github.com/johnlokerse/bicep-registry-modules/actions/workflows/avm.res.compute.virtual-machine.yml){kind=link}
…k - `avm/res/compute/virtual-machine` (Azure#1517) ## Description This pull request adds UDTs for OS disk and data disk. Also, included the option to give a custom name to either disk. ## Pipeline Reference | Pipeline | | -------- | | [](https://github.com/johnlokerse/bicep-registry-modules/actions/workflows/avm.res.compute.virtual-machine.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [ ] I'm sure there are no other open Pull Requests for the same update/change - [ ] I have run `Set-AVMModule` locally to generate the supporting module files. - [ ] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Rainer Halanek <61878316+rahalan@users.noreply.github.com>
Description
This pull request adds UDTs for OS disk and data disk. Also, included the option to give a custom name to either disk.
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.