-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Enable geo-replication for Redis cache. #2411
Comments
I've tried to provide some kind of start of an implementation here: Azure/ResourceModules@main...Meertman:ResourceModules:main But it is far from complete. |
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
Hey @hundredacres, |
Warning Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly. Tip
|
Working on some tests to validate this functionality. |
PR here: #2562 |
## Description Add support for geo-replication and a test to validate it's working. Fixes #2411 Closes #2411 ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [![avm.res.cache.redis](https://github.com/hundredacres/bicep-registry-modules/actions/workflows/avm.res.cache.redis.yml/badge.svg?branch=feat%2Fissue%2F2411)](https://github.com/hundredacres/bicep-registry-modules/actions/workflows/avm.res.cache.redis.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [X] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [X] I'm sure there are no other open Pull Requests for the same update/change - [X] I have run `Set-AVMModule` locally to generate the supporting module files. - [X] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Máté Barabás <barabasmate@gmail.com> Co-authored-by: Rainer Halanek <61878316+rahalan@users.noreply.github.com> Co-authored-by: JFolberth <johnfolberth@gmail.com>
@hundredacres, does this also work with private endpoints enabled? In the past I ran into issues with this? (and even created a GitHub issue on bicep for this: Azure/bicep-types-az#1937) |
Description
A Redis cache supports the setup of geo-replication via bicep through the use of the linked server bicep resource: https://learn.microsoft.com/en-us/azure/templates/microsoft.cache/redis/linkedservers?pivots=deployment-language-bicep
Adding this to the bicep module for deployment of a Redis cache would be a welcome addition.
However the usage of the linked server and a private endpoint proves to be a bit difficult as you cannot add a private link to a Redis cache that is geo-replicated. You first need to remove the geo-replication, then add the link and then re-enable the geo-replication. As documented here: https://learn.microsoft.com/en-us/azure/azure-cache-for-redis/cache-how-to-geo-replication
Specifically:
The text was updated successfully, but these errors were encountered: