feat: Update Private Endpoints implementation across the modules #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
matebarabas
added
Type: Feature Request ➕
…into users/krbar/peScope
…into users/krbar/peScope
8 tasks
krbar
changed the title
AlexanderSehr
previously approved these changes
Apr 7, 2024
AlexanderSehr
approved these changes
Apr 7, 2024
segraef
pushed a commit
to segraef/bicep-registry-modules
that referenced
this pull request
Apr 8, 2024
…re#1472) ## Description Updates to the implementation of private endpoint in multiple modules: - Enabled custom resource group selection for Private Endpoints. - Fixing outdated PE property `manualPrivateLinkServiceConnections` > Note: the module `avm/res/search/search-service` which also required this update, has been updated via Azure#1475 > Several other modules have been excluded from this PR because they could not be merged at this time. Their PR implementation update will be tracked via Azure#1583 Resolves Azure#1190 <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes Azure#123 Fixes Azure#456 Closes Azure#123 Closes Azure#456 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.batch.batch-account.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.cache.redis.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.cognitive-services.account.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.data-factory.factory.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.desktop-virtualization.host-pool.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.desktop-virtualization.workspace.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.digital-twins.digital-twins-instance.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.event-grid.domain.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.event-grid.namespace.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.event-grid.topic.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.insights.private-link-scope.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.purview.account.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.recovery-services.vault.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.relay.namespace.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.search.search-service.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.service-bus.namespace.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.signal-r.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.web-pub-sub.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.sql.server.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.synapse.private-link-hub.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.synapse.workspace.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.web.static-site.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep -->
8 tasks
AlexanderSehr
added a commit
that referenced
this pull request
Apr 11, 2024
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.batch.batch-account.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.cache.redis.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.cognitive-services.account.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.data-factory.factory.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.desktop-virtualization.host-pool.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.desktop-virtualization.workspace.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.digital-twins.digital-twins-instance.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.event-grid.domain.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.event-grid.namespace.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.event-grid.topic.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.insights.private-link-scope.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.purview.account.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.recovery-services.vault.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.relay.namespace.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.search.search-service.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.service-bus.namespace.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.signal-r.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.web-pub-sub.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.sql.server.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.synapse.private-link-hub.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.synapse.workspace.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.web.static-site.yml){kind=link}
…ivate Endpoint UDT (#1614) ## Description To enable users to set an explicit `privateLinkServiceConnectionName` it must be defined in the UDT where it was missing. Updated for all modules that @krbar updated in his preceeding PR #1472  ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.batch.batch-account.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.cache.redis.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.cognitive-services.account.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.data-factory.factory.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.digital-twins.digital-twins-instance.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.event-grid.domain.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.event-grid.namespace.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.event-grid.topic.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.insights.private-link-scope.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.purview.account.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.recovery-services.vault.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.relay.namespace.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.search.search-service.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.service-bus.namespace.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.signal-r.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.web-pub-sub.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.sql.server.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.synapse.private-link-hub.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.synapse.workspace.yml) ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [x] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation --------- Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.batch.batch-account.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.cache.redis.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.cognitive-services.account.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.data-factory.factory.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.digital-twins.digital-twins-instance.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.event-grid.domain.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.event-grid.namespace.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.event-grid.topic.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.insights.private-link-scope.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.purview.account.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.recovery-services.vault.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.relay.namespace.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.search.search-service.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.service-bus.namespace.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.signal-r.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.web-pub-sub.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.sql.server.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.synapse.private-link-hub.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.synapse.workspace.yml){kind=link}
segraef
pushed a commit
to segraef/bicep-registry-modules
that referenced
this pull request
Apr 17, 2024
…ivate Endpoint UDT (Azure#1614) ## Description To enable users to set an explicit `privateLinkServiceConnectionName` it must be defined in the UDT where it was missing. Updated for all modules that @krbar updated in his preceeding PR Azure#1472  ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.batch.batch-account.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.cache.redis.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.cognitive-services.account.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.data-factory.factory.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.digital-twins.digital-twins-instance.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.event-grid.domain.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.event-grid.namespace.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.event-grid.topic.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.insights.private-link-scope.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.purview.account.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.recovery-services.vault.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.relay.namespace.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.search.search-service.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.service-bus.namespace.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.signal-r.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.signal-r-service.web-pub-sub.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.sql.server.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.synapse.private-link-hub.yml) [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.synapse.workspace.yml) ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [x] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation --------- Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to the implementation of private endpoint in multiple modules:
manualPrivateLinkServiceConnectionsResolves #1190
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.