Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only exclude shared properties from tagged union branches, not all inherited properties #1020

Merged
merged 1 commit into from Aug 25, 2022

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Aug 11, 2022

Resolves #954 and resolves #365 and resolves #1048

Test type generation run viewable at #1021

@jeskew jeskew requested a review from a team August 11, 2022 16:53
@jeskew jeskew marked this pull request as draft August 11, 2022 16:57
@codecov-commenter
Copy link

Codecov Report

Merging #1020 (ec73c6f) into main (243a5b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1020   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files          18       18           
  Lines         317      317           
=======================================
  Hits          304      304           
  Misses         13       13           
Flag Coverage Δ
dotnet 95.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jeskew jeskew marked this pull request as ready for review August 11, 2022 18:54
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jeskew jeskew force-pushed the jeskew/union-base-property-exclusion-refinement branch from ec73c6f to 847c476 Compare August 25, 2022 17:55
@jeskew jeskew enabled auto-merge (squash) August 25, 2022 17:57
@jeskew jeskew merged commit 5438211 into main Aug 25, 2022
@jeskew jeskew deleted the jeskew/union-base-property-exclusion-refinement branch August 25, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants