Use the latest autorest libraries for type generation #146
Conversation
anthony-c-martin
force-pushed
the
typescript
branch
4 times, most recently
from
d935f3a
to
090d74b
Compare
anthony-c-martin
force-pushed
the
typescript
branch
from
090d74b
to
0562c4c
Compare
anthony-c-martin
changed the title
anthony-c-martin
force-pushed
the
typescript
branch
from
8ad9a31
to
0b47976
Compare
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 93.65% 95.23% +1.58%
==========================================
Files 17 17
Lines 252 252
==========================================
+ Hits 236 240 +4
+ Misses 16 12 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Does running the new generator on the same commit as the old one produce an empty diff or a diff with "good" changes? |
| flags |= ObjectPropertyFlags.ReadOnly; | ||
| } | ||
|
|
||
| if (!getProperty) { |
There was a problem hiding this comment.
Should we also handle "secret": true and "x-ms-mutability": ["create", "update"]?
There was a problem hiding this comment.
Good point. I'll raise an issue for this, as the intention with this PR is to reach parity with the current generator.
Yes - I used the diffs heavily to progressively work towards this implementation. I spent some time going through the final product and coudln't find anything major other than naming and formatting differences. |
This PR contains the code changes to switch from C# type generation to TypeScript.
The motivation is that the library we're using (https://github.com/Azure/autorest.common) is not being actively maintained, with modern extensions being authored using https://github.com/Azure/autorest/tree/master/packages/extensions/modelerfour