Handle x-ms-mutability swagger extension #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #436 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 17 17
Lines 252 252
=======================================
Hits 240 240
Misses 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
majastrz
reviewed
Sep 30, 2021
| @@ -294,13 +294,37 @@ export function generateTypes(host: Host, definition: ProviderDefinition) { | |||
| return factory.lookupBuiltInType(BuiltInTypeKind.Any); | |||
| } | |||
|
|
|||
| function getMutabilityFlags(property: Property | undefined) { | |||
| const mutability = property?.extensions?.["x-ms-mutability"] as string[]; | |||
There was a problem hiding this comment.
I think you also need to handle x-ms-secret: true and format: password cases. I sent you an IM about how we're dealing with that in an internal repo that is partially applicable.
If something is considered secret, we should assume write only and it should take precedence over whatever x-ms-mutability settings in the swagger.
There was a problem hiding this comment.
I've raised #437 to track this separately as this PR is just to fix a specific scenario. I feel like the handling of x-ms-secret in types needs a bit more discussion.
majastrz
approved these changes
Sep 30, 2021
This was referenced May 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #240