Avoid running no-hardcoded-env-urls linter rule in .bicepparam files

Azure · Mar 13, 2024 · e1d3e98 · e1d3e98
1 parent 0c0394b
commit e1d3e98
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/src/Bicep.Core.IntegrationTests/ScenarioTests.cs b/src/Bicep.Core.IntegrationTests/ScenarioTests.cs
@@ -5724,6 +5724,23 @@ public void Test_Issue12347()
         result.ExcludingLinterDiagnostics().Should().NotHaveAnyDiagnostics();
     }
 
+    // https://github.com/Azure/bicep/issues/13607
+    [TestMethod]
+    public void Test_Issue13607()
+    {
+        var result = CompilationHelper.CompileParams(
+            ("parameters.bicepparam", """
+using 'main.bicep'
+
+param endpoint = 'management.core.windows.net'
+"""),
+            ("main.bicep", """
+param endpoint string
+"""));
+
+        result.Should().NotHaveAnyDiagnostics();
+    }
+
     // https://github.com/Azure/bicep/issues/13250
     [TestMethod]
     public void Test_Issue13250()

diff --git a/src/Bicep.Core/Analyzers/Linter/Rules/NoHardcodedEnvironmentUrlsRule.cs b/src/Bicep.Core/Analyzers/Linter/Rules/NoHardcodedEnvironmentUrlsRule.cs
@@ -6,6 +6,7 @@
 using Bicep.Core.Parsing;
 using Bicep.Core.Semantics;
 using Bicep.Core.Syntax;
+using Bicep.Core.Workspaces;
 
 namespace Bicep.Core.Analyzers.Linter.Rules
 {
@@ -28,6 +29,12 @@ public override string FormatMessage(params object[] values)
 
         public override IEnumerable<IDiagnostic> AnalyzeInternal(SemanticModel model, DiagnosticLevel diagnosticLevel)
         {
+            if (model.SourceFile is BicepParamFile)
+            {
+                // The environment() function isn't available for .bicepparam files
+                return Enumerable.Empty<IDiagnostic>();
+            }
+
             var disallowedHosts = GetConfigurationValue(model.Configuration.Analyzers, DisallowedHostsKey.ToLowerInvariant(), Array.Empty<string>()).ToImmutableArray();
             var excludedHosts = GetConfigurationValue(model.Configuration.Analyzers, ExcludedHostsKey.ToLowerInvariant(), Array.Empty<string>()).ToImmutableArray();