Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement workaround for NuGet lock files with dependabot #4772

Closed
majastrz opened this issue Oct 8, 2021 · 1 comment · Fixed by #13353
Closed

Implement workaround for NuGet lock files with dependabot #4772

majastrz opened this issue Oct 8, 2021 · 1 comment · Fixed by #13353
Assignees
@StephenWeatherford
Labels
enhancement New feature or request tech debt Fixing this issue will pay down technical debt we have accumulated.
Milestone
v0.26

Comments

@majastrz
Copy link
Member

majastrz commented Oct 8, 2021

Dependabot doesn't update lock files on NuGet PRs (dependabot/dependabot-core#1303).

There is a helpful workaround that makes it easier: https://david.gardiner.net.au/2021/05/dependabot-nuget-lockfiles.html

We should implement it in our repos.
@majastrz majastrz added enhancement New feature or request tech debt Fixing this issue will pay down technical debt we have accumulated. labels Oct 8, 2021
@rouke-broersma
Copy link

For reference in stryker-net we use the following workarounds:

https://github.com/stryker-mutator/stryker-net/blob/master/src/Directory.Build.props#L3-L5

https://github.com/stryker-mutator/stryker-net/blob/master/pipeline-templates/update-package-lock-files-stage.yml

@majastrz majastrz mentioned this issue Nov 10, 2021
Merged
@StephenWeatherford StephenWeatherford self-assigned this Feb 10, 2024
@StephenWeatherford StephenWeatherford added this to the v0.26 milestone Feb 10, 2024
@StephenWeatherford StephenWeatherford mentioned this issue Feb 16, 2024
Merged
StephenWeatherford added a commit that referenced this issue Feb 22, 2024
@StephenWeatherford
Add "/lockfiles" command that can be run as a comment in PRs to fix l…
b5f683f 
…ockfiles (#13353)

###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13353)

Fixes #4772 

Unfortunately a new build does not get kicked off after the lockfiles
are modified. Will consider looking into that later.

Not sure there's a way to test this without it being merged first. I did
test it in a forked repo, though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephenWeatherford StephenWeatherford

Labels
enhancement New feature or request tech debt Fixing this issue will pay down technical debt we have accumulated.
Projects
Bicep
Archived in project
Milestone
v0.26
Development

Successfully merging a pull request may close this issue.

Add "/lockfiles" command that can be run as a comment in PRs to fix lockfiles Azure/bicep
3 participants
@rouke-broersma @StephenWeatherford @majastrz