Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch case-insensitive clashes of type property names #11457

Merged
merged 1 commit into from Aug 3, 2023
Merged

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Aug 3, 2023

As a follow-up to #11453, this PR updates the case-insensitive name clash detector to look at type properties, too, since these are also case-insensitive in ARM.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/Azure/bicep/pull/11457&drop=dogfoodAlpha

@jeskew jeskew requested a review from a team August 3, 2023 22:05
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Test Results (osx-x64)

       33 files  ±0         33 suites  ±0   1h 23m 42s ⏱️ - 4m 38s
10 299 tests ±0  10 299 ✔️ ±0  0 💤 ±0  0 ±0 
12 516 runs  ±0  12 516 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit c85edb9. ± Comparison against base commit 2b6539d.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Test Results (win-x64)

       33 files  ±0         33 suites  ±0   32m 17s ⏱️ + 2m 49s
10 307 tests ±0  10 307 ✔️ ±0  0 💤 ±0  0 ±0 
12 523 runs  ±0  12 523 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit c85edb9. ± Comparison against base commit 2b6539d.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Test Results (linux-musl-x64)

       33 files  ±0         33 suites  ±0   30m 36s ⏱️ - 3m 55s
10 295 tests ±0  10 295 ✔️ ±0  0 💤 ±0  0 ±0 
12 512 runs  ±0  12 512 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit c85edb9. ± Comparison against base commit 2b6539d.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Test Results (linux-x64)

       33 files  ±0         33 suites  ±0   37m 35s ⏱️ + 3m 29s
10 295 tests ±0  10 295 ✔️ ±0  0 💤 ±0  0 ±0 
12 512 runs  ±0  12 512 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit c85edb9. ± Comparison against base commit 2b6539d.

@jeskew jeskew enabled auto-merge (squash) August 3, 2023 22:30
@jeskew jeskew merged commit 09d0d4b into main Aug 3, 2023
52 checks passed
@jeskew jeskew deleted the jeskew/502-bis branch August 3, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants