Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validate-params command #11476

Merged
merged 7 commits into from Aug 24, 2023
Merged

Add validate-params command #11476

merged 7 commits into from Aug 24, 2023

Conversation

Usman0111
Copy link
Contributor

@Usman0111 Usman0111 commented Aug 10, 2023

To allow Azure Cli/PowerShell to validate parameters that are passed in-line, following validate-params command needs to be added to the Bicep Cli:

bicep validate-params <bicep-file-path> --params <name-value-pairs-of-params>

This is an auxiliary command that is not meant to be used by users directly

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/Azure/bicep/pull/11476&drop=dogfoodAlpha

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Test Results (linux-musl-x64)

       33 files  ±0         33 suites  ±0   38m 0s ⏱️ + 4m 29s
10 412 tests +3  10 376 ✔️ +3  36 💤 ±0  0 ±0 
12 629 runs  +3  12 593 ✔️ +3  36 💤 ±0  0 ±0 

Results for commit 0822f89. ± Comparison against base commit 2cb2504.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Test Results (linux-x64)

       33 files  ±0         33 suites  ±0   32m 43s ⏱️ - 1m 43s
10 412 tests +3  10 376 ✔️ +3  36 💤 ±0  0 ±0 
12 629 runs  +3  12 593 ✔️ +3  36 💤 ±0  0 ±0 

Results for commit 0822f89. ± Comparison against base commit 2cb2504.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Test Results (osx-x64)

       33 files  ±0         33 suites  ±0   1h 22m 50s ⏱️ - 7m 31s
10 416 tests +3  10 380 ✔️ +3  36 💤 ±0  0 ±0 
12 633 runs  +3  12 597 ✔️ +3  36 💤 ±0  0 ±0 

Results for commit 0822f89. ± Comparison against base commit 2cb2504.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Test Results (win-x64)

       33 files  ±0         33 suites  ±0   41m 55s ⏱️ + 6m 12s
10 424 tests +3  10 388 ✔️ +3  36 💤 ±0  0 ±0 
12 640 runs  +3  12 604 ✔️ +3  36 💤 ±0  0 ±0 

Results for commit 0822f89. ± Comparison against base commit 2cb2504.

♻️ This comment has been updated with latest results.

@Usman0111 Usman0111 marked this pull request as ready for review August 11, 2023 15:26
Copy link
Contributor

@jeskew jeskew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two optional suggestions; otherwise LGTM.

src/Bicep.Cli/Commands/ValidateParamsCommand.cs Outdated Show resolved Hide resolved
@Usman0111 Usman0111 merged commit 8163596 into main Aug 24, 2023
52 of 57 checks passed
@Usman0111 Usman0111 deleted the Usman0111/validate-params-command branch August 24, 2023 16:37
Usman0111 added a commit that referenced this pull request Oct 2, 2023
Undoing [work](#11476) for
`validate-params` command since we have decided to switch to validating
inline params through `build-params` command
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/11974)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants