Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform deep validation on assigned parameter values in .bicepparam files #11985

Merged
merged 1 commit into from Oct 1, 2023

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Sep 29, 2023

Resolves #11981

Type analysis in .bicepparam files is currently only performing an assignability (shallow type affinity) check. This PR updates that analysis to use the TypeValidator's deep validation method to match how parameter default values and resource bodies are checked.

Microsoft Reviewers: Open in CodeFlow

@jeskew jeskew requested a review from a team September 29, 2023 17:14
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

Test this change out locally with the following install scripts (Action run 6371695266)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6371695266
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6371695266"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6371695266
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6371695266"

@github-actions
Copy link
Contributor

Test Results

     132 files  ±0       132 suites  ±0   3h 37m 18s ⏱️ + 7m 8s
10 659 tests +1  10 659 ✔️ +1  0 💤 ±0  0 ±0 
51 503 runs  +4  51 503 ✔️ +4  0 💤 ±0  0 ±0 

Results for commit 45c360d. ± Comparison against base commit 65a5dee.

@jeskew jeskew enabled auto-merge (squash) September 29, 2023 22:11
@jeskew jeskew merged commit 3932dc0 into main Oct 1, 2023
47 checks passed
@jeskew jeskew deleted the jeskew/11981 branch October 1, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User defined types - sealed decorator not working in bicep parameters files
2 participants