Example of Condition deploy logging resource for Web App #1199
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1199 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 336 336
Lines 16825 16825
Branches 14 14
=======================================
Hits 15898 15898
Misses 927 927
Flags with carried forward coverage won't be shown. Click here to find out more. |
| } | ||
| } | ||
|
|
||
| resource appServiceAppSettings 'Microsoft.Web/sites/config@2020-06-01' = if (logging) { |
There was a problem hiding this comment.
since the if (logging) condition is used multiple times, it may make sense to put all of those resources in a module and then conditionally deploy the module. That is a personal preference, so I will leave that to you
There was a problem hiding this comment.
That makes sense and can see that viewpoint. I think part of the question is overall how modules should be scoped. So far I've taken it from the individual resources as opposed to in this case the feature set of logging. Think realistically for this one a single logging module makes more sense.
Thanks for the feedback! I will update accordingly.
| var appInsightName = toLower('appi-${appName}') | ||
| var logAnalyticsName = toLower('la-${appName}') | ||
|
|
||
| resource appServiceAppSettings 'Microsoft.Web/sites/config@2020-06-01' = if (logging) { |
There was a problem hiding this comment.
I don't think you need the if (logging) checks in the module, since the whole module will not be called unless the condition of the module is met in main.bicep. So you should be able to remove the logging param entirely
There was a problem hiding this comment.
I wondered this and actually did put it at the module level....just left it inside. I did remove it and retest deployment. Got the same result.
Code changes pushed up.
There was a problem hiding this comment.
Thanks for the help!
Tried new condition functionality to see how it would work. Figured commit it back for others.