Fix compiled representation of wildcard variable property references #12048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this change out locally with the following install scripts (Action run 6409533970) VSCode
Azure CLI
|
jeskew
added a commit
that referenced
this pull request
Oct 6, 2023
…ses (#12055) Resolves #12052 A recent PR (#12048) updated TemplateWriter to preprocess a template's references to imported symbols. This new step uses an `ExpressionRewriteVisitor`, which had not been kept up to date when new properties were added various kinds of IR expressions. The PR also adds a few more lines to the `Imports_LF` baseline scenario to exercise additional behavior. The scenario had originally been written to validate the mechanics of importing types and variables but didn't cover the mechanics of *using* imported symbols in a template. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/12055)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12042
#11879 introduced a regression in references to variables imported with via wildcard syntax were represented in a template's compiled form. For example,
would generate a value of
"[variables('mod').s]"in the compiled template. When implementing variable imports for.bicepparamfiles, I took the shortcut of generating a object value for wildcard imports whose properties were all the variables exported from the imported model. There was a gap in test coverage for variable imports in.bicepfiles, so the regression was not picked up. This PR updates how wildcard imports are handled in.bicepparamfiles to remove the aforementioned shortcut.The PR also adds an extra step in
TemplateWriter: after.bicepfiles are converted to the compiler's intermediate representation, expressions referring to imported values are replaced with expressions that refer to "synthetic" variables and types.Microsoft Reviewers: Open in CodeFlow