Update CyclicCheckVisitor to prohibit self references within an access expression in type syntax

[jeskew]

Resolves #12070

CyclicTypeVisitor permits cycles within type expressions to allow for recursive type definitions. However, this can cause an unhandled stack overflow when a property or array access expression is within a "type container expression" (e.g., ObjectTypePropertySyntax), since access expressions will try to resolve the type of their base expression. For example:

type UsesPermittedRecursion = {
  property: UsesPermittedRecursion? // <-- this is the kind of recursion we want to allow
}

type CausesStackOverflow = {
  property: CausesStackOverflow.property // <-- this wouldn't be a valid type, but we should show a diagnostic, not blow the stack
}

Microsoft Reviewers: Open in CodeFlow

[github-actions]

Test this change out locally with the following install scripts (Action run 6486604798)

VSCode

• Mac/Linux

  bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6486604798

• Windows

  iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6486604798"

Azure CLI

• Mac/Linux

  bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6486604798

• Windows

  iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6486604798"

[github-actions]

Test Results

     132 files  ±  0       132 suites  ±0   3h 51m 56s ⏱️ - 6m 29s
10 671 tests +  3  10 671 ✔️ +  3  0 💤 ±0  0 ❌ ±0 
51 551 runs  +12  51 551 ✔️ +12  0 💤 ±0  0 ❌ ±0 

Results for commit 80b1463. ± Comparison against base commit 5684992.

♻️ This comment has been updated with latest results.